[Tor Trac #32363]: Check for leading zeros in tor_inet_aton()

[neelchauhan]

Ticket: https://trac.torproject.org/projects/tor/ticket/32363

[coveralls]

Pull Request Test Coverage Report for Build 7853

• 8 of 8 (100.0%) changed or added relevant lines in 1 file are covered.
• 4111 unchanged lines in 31 files lost coverage.
• Overall coverage increased (+0.2%) to 63.333%

---

Files with Coverage Reduction	New Missed Lines	%
src/core/mainloop/mainloop.c	1	37.55%
src/core/or/channeltls.c	1	42.54%
src/feature/hs/hs_circuit.c	2	41.57%
src/core/mainloop/connection.h	3	50.0%
src/feature/client/transports.c	3	52.95%
src/feature/dirauth/authmode.c	5	66.67%
src/feature/nodelist/nodelist.c	5	71.36%
src/feature/nodelist/fmt_routerstatus.c	11	82.35%
src/app/main/main.c	15	22.04%
src/feature/dirauth/bwauth.c	15	89.53%

Totals
Change from base Build 7691:	0.2%
Covered Lines:	49954
Relevant Lines:	78875

---

💛 - Coveralls

[dgoulet-tor]

octet contains junk at the start of the loop so what happens if we end up here at the first iteration where octet was never set?

[neelchauhan]

The tor_sscanf() check should prevent this.

[dgoulet-tor]

Ok I think I know what you mean as in we can only get in that if() with a malformed address and the sscanf doesn't allow that.

I would really love to still do have char octet[4] = {0}; just for safety and future proofing this. As in setting it to zeroes at first.