Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tor Trac #32614]: Flag a v3 intro point as bad if rendezvous fails during cleanup #1653

Closed
wants to merge 2 commits into from
Closed

[Tor Trac #32614]: Flag a v3 intro point as bad if rendezvous fails during cleanup #1653

wants to merge 2 commits into from

Conversation

Reviewers

@dgoulet-tor dgoulet-tor

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@neelchauhan @coveralls @dgoulet-tor @torproject-pusher
@neelchauhan
Copy link
Contributor

@neelchauhan neelchauhan commented Jan 12, 2020

Ticket: https://trac.torproject.org/projects/tor/ticket/32614
@coveralls
Copy link

@coveralls coveralls commented Jan 12, 2020 •
edited

Pull Request Test Coverage Report for Build 7739

  • 4 of 9 (44.44%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.004%) to 63.332%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/feature/hs/hs_client.c 3 8 37.5%
Files with Coverage Reduction New Missed Lines %
src/feature/hs/hs_common.c 1 84.27%
Totals Coverage Status
Change from base Build 7725: -0.004%
Covered Lines: 49954
Relevant Lines: 78877
💛 - Coveralls

neelchauhan added 2 commits Jan 12, 2020
@neelchauhan
Flag a v3 intro point as bad if rendezvous fails during cleanup
7999fc8
@neelchauhan
Add ChangeLog entry for Ticket #32614
60ef98c
dgoulet-tor
dgoulet-tor reviewed Jan 22, 2020
View changes
src/feature/hs/hs_client.c

tor_assert(circ);
tor_assert(CIRCUIT_IS_ORIGIN(circ));

orig_circ = CONST_TO_ORIGIN_CIRCUIT(circ);
tor_assert(orig_circ->hs_ident);

intro_circ = hs_circuitmap_get_intro_circ_v3_service_side(
&orig_circ->hs_ident->intro_auth_pk);

Copy link
Contributor

@dgoulet-tor dgoulet-tor Jan 22, 2020

There is quite a bit of wrong with this. This is service side, you can't use the HS circuit map to lookup a service side circuit on the client side.

We actually don't register the client introduction circuit into the map. Also, you assume intro_circ is never NULL here which can't be guaranteed.

This needs to be tested properly...

@torproject-pusher torproject-pusher deleted the branch torproject:master May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment