Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_practracker.sh: never disable practracker #1658

Merged
merged 1 commit into from Jan 14, 2020
Merged

test_practracker.sh: never disable practracker #1658

merged 1 commit into from Jan 14, 2020

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@nmathewson @coveralls @torproject-pusher
@nmathewson
Copy link
Contributor

@nmathewson nmathewson commented Jan 13, 2020

When practracker is disabled, its output will be empty. We don't
want that happening during our tests.

Fixes bug 32705; bugfix on 0.4.2.1-alpha, when test_practracker.sh
was introduced.
@nmathewson
test_practracker.sh: never disable practracker
6b1592b 
When practracker is disabled, its output will be empty.  We don't
want that happening during our tests.

Fixes bug 32705; bugfix on 0.4.2.1-alpha, when test_practracker.sh
was introduced.
@coveralls
Copy link

@coveralls coveralls commented Jan 13, 2020

Pull Request Test Coverage Report for Build 7754

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 62.278%
Totals Coverage Status
Change from base Build 7684: 0.0%
Covered Lines: 48482
Relevant Lines: 77848
💛 - Coveralls

@torproject-pusher torproject-pusher merged commit 6b1592b into torproject:maint-0.4.2 Jan 14, 2020
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment