Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace an assertion with a check-and-log #1661

Merged

Conversation

Labels
None yet
Projects
None yet
3 participants
@nmathewson
Copy link
Contributor

@nmathewson nmathewson commented Jan 14, 2020

We hit this assertion with bug 32868, but I'm stymied figuring out
how we wound up with a routerstatus like this. This patch is a
diagnostic to attempt to figure out what is going on, and to avoid a
crash in the meantime.

We hit this assertion with bug 32868, but I'm stymied figuring out
how we wound up with a routerstatus like this.  This patch is a
diagnostic to attempt to figure out what is going on, and to avoid a
crash in the meantime.
@coveralls
Copy link

@coveralls coveralls commented Jan 14, 2020

Pull Request Test Coverage Report for Build 7772

  • 1 of 20 (5.0%) changed or added relevant lines in 1 file are covered.
  • 13 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+1.7%) to 60.864%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/feature/nodelist/node_select.c 1 20 5.0%
Files with Coverage Reduction New Missed Lines %
src/feature/dirauth/shared_random.c 4 85.1%
src/feature/dirauth/dirvote.c 9 64.65%
Totals Coverage Status
Change from base Build 7615: 1.7%
Covered Lines: 44551
Relevant Lines: 73198

💛 - Coveralls

@torproject-pusher torproject-pusher merged commit 98e1472 into torproject:maint-0.3.5 Oct 7, 2020
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment