Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ticket32487 squashed and merged #1669

Merged
merged 13 commits into from Jan 17, 2020
Merged

Ticket32487 squashed and merged #1669

merged 13 commits into from Jan 17, 2020

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@nmathewson @coveralls @torproject-pusher
@nmathewson
Copy link
Contributor

@nmathewson nmathewson commented Jan 16, 2020

No description provided.

nmathewson added 13 commits Jan 16, 2020
@nmathewson
Define a "dircache" module.
888a0be 
For now, this module is enabled whenever the relay module is
enabled, and disabled whenever the relay module is disabled.  Though
they are logically separate, the use cases for running one without
the other are rare enough that we don't really want to support
compiling them independently.
@nmathewson
Move dir_split_resource_into_spoolable() to dircache module.
4cf15ee 
Only directory caches actually need to spool things.
@nmathewson
Move dirserv_get_routerdescs() to control_getinfo.c
fe8156d 
This function had some XXX comments indicating (correctly) that it
was not actually used by the dirserver code, and that only the
controller still used it.
@nmathewson
Use dir_conn_clear_spool() in connection.c.
6e12a8f 
This is cleaner than iterating over the spool.
@nmathewson
Disable feature/dircache files when dircache module is disabled.
8a0c739 
To make Tor still work, we define a minimal dircache_stub.c file
that defines the entry points to the module that can actually be
seen by the compiler when we're building with dircache and relay
disabled.
@nmathewson
Add a changes file for disabling the dircache code.
a1bc471
@nmathewson
Move dirclient-related functions out of dirserv, and reenable them
773bcf5 
I had incorrectly identified these functions as dircache-only, when
in fact they apply to everyone who acts a directory client.
@nmathewson
Move directory_must_use_begindir() to dirclient_modes.[ch]
8d1f311
@nmathewson
Rename dirclient_modes.h identifiers to start with dirclient_
6ba4b5e 
This is an automated commit, generated by this command:

./scripts/maint/rename_c_identifier.py \
        directory_must_use_begindir dirclient_must_use_begindir \
        directory_fetches_from_authorities dirclient_fetches_from_authorities \
        directory_fetches_dir_info_early dirclient_fetches_dir_info_early \
        directory_fetches_dir_info_later dirclient_fetches_dir_info_later \
        directory_too_idle_to_fetch_descriptors dirclient_too_idle_to_fetch_descriptors
@nmathewson
Turn several functions from stubs into macros
5cff1ce 
This may help the compiler eliminate deadcode.
@nmathewson
Add have_module_dircache().
a623a49
@nmathewson
Document why dircache is not included in --list-modules
efb301c
@nmathewson
Merge branch 'ticket32487_squashed' into ticket32487_squashed_and_merged
3c89622 
Resolved conflicts in src/core/include.am
@coveralls
Copy link

@coveralls coveralls commented Jan 16, 2020

Pull Request Test Coverage Report for Build 7805

  • 48 of 98 (48.98%) changed or added relevant lines in 12 files are covered.
  • 15 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.02%) to 63.319%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/feature/nodelist/node_select.c 1 2 50.0%
src/feature/nodelist/nodelist.c 0 1 0.0%
src/core/mainloop/mainloop.c 1 3 33.33%
src/app/config/config.c 0 4 0.0%
src/feature/dirclient/dirclient.c 2 6 33.33%
src/feature/control/control_getinfo.c 0 38 0.0%
Files with Coverage Reduction New Missed Lines %
src/app/config/config.c 1 79.76%
src/core/mainloop/mainloop.c 1 37.55%
src/feature/dirauth/shared_random.c 4 85.0%
src/feature/dirauth/dirvote.c 9 64.85%
Totals Coverage Status
Change from base Build 7796: -0.02%
Covered Lines: 49949
Relevant Lines: 78885
💛 - Coveralls

@torproject-pusher torproject-pusher merged commit 3c89622 into torproject:master Jan 17, 2020
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment