Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ticket20218 merged #1673

Merged
merged 9 commits into from Jan 20, 2020
Merged

Ticket20218 merged #1673

merged 9 commits into from Jan 20, 2020

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@teor2345 @coveralls @torproject-pusher @vnepveu @nmathewson
@teor2345
Copy link
Contributor

@teor2345 teor2345 commented Jan 20, 2020

No description provided.

vnepveu and others added 2 commits Jan 16, 2020
@vnepveu @nmathewson
Refactor routerstatus_has_changed function
594e5ce 
- Check all fields that might change in a routerstatus
- Document the refactoring

Signed-off-by: Victor Nepveu <victor.nepveu@imt-atlantique.net>
@nmathewson
expose routerstatus_has_changed to unit tests.
60a0d7d
@teor2345
Copy link
Contributor Author

@teor2345 teor2345 commented Jan 20, 2020

Resolves merge conflict in #1670.

@teor2345 teor2345 closed this Jan 20, 2020
@teor2345 teor2345 reopened this Jan 20, 2020
@teor2345 teor2345 mentioned this pull request Jan 20, 2020
Closed
@coveralls
Copy link

@coveralls coveralls commented Jan 20, 2020 •
edited

Pull Request Test Coverage Report for Build 7825

  • 8 of 9 (88.89%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 63.34%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/feature/nodelist/networkstatus.c 8 9 88.89%
Totals Coverage Status
Change from base Build 7815: 0.03%
Covered Lines: 49956
Relevant Lines: 78869
💛 - Coveralls

nmathewson and others added 7 commits Jan 20, 2020
@nmathewson @teor2345
Add unit test for routerstatus_has_changed()
702a753
@nmathewson @teor2345
Update routerstatus_has_changed tests.
c3633e6 
Now they also check whether output of routerstatus_format_entry()
has changed.
@nmathewson @teor2345
Rename routerstatus_has_changed to routerstatus_has_visibly_changed
152cbf2 
This is an automated commit, generated by this command:

./scripts/maint/rename_c_identifier.py \
        routerstatus_has_changed routerstatus_has_visibly_changed

It was generated with --no-verify, since it introduces a wide line.
I'll fix it in a subsequent commit.
@nmathewson @teor2345
split a wide line
e263721
@nmathewson @teor2345
Rename test to match new identifier.
4541289
@teor2345
Merge branch 'ticket20218_rebased_squashed' into ticket20218_merged
3851128 
* ticket 32695 removed networkstatus_consensus_has_ipv6(),
  keep that change in master.
* ticket 20218 modifies the function name and comment for
  routerstatus_has_visibly_changed(), keep that change
  in ticket20218_rebased_squashed.
@teor2345
test/nodelist: Remove ROUTERSTATUS_FORMAT_NO_CONSENSUS_METHOD
af30be9 
When we removed obsolete consensus methods in 32695, we also
removed ROUTERSTATUS_FORMAT_NO_CONSENSUS_METHOD, so we need to
remove it from the routerstatus format tests.

Part of 20218.
@teor2345 teor2345 force-pushed the ticket20218_merged branch from 016e95c to af30be9 Jan 20, 2020
@torproject-pusher torproject-pusher merged commit af30be9 into torproject:master Jan 20, 2020
0 of 2 checks passed
@vnepveu vnepveu mentioned this pull request May 5, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment