Ticket32709 044 02 #1679
Merged
Ticket32709 044 02 #1679
Conversation
The hs_parse_address() can not be used without an options_t object existing since on error it uses the escaped_safe_str() that looks at the options. This new function won't log and returns an error message in case of failure that can then be used to log. Signed-off-by: David Goulet <dgoulet@torproject.org>
Part of #32709 Signed-off-by: David Goulet <dgoulet@torproject.org>
At this commit, the service reads the config file and parse it to finally set the service config object with the options. Part of #32709 Signed-off-by: David Goulet <dgoulet@torproject.org>
Closes #32709 Signed-off-by: David Goulet <dgoulet@torproject.org>
Pointed by nickm during the review of #32709. Signed-off-by: David Goulet <dgoulet@torproject.org>
Signed-off-by: David Goulet <dgoulet@torproject.org>
Signed-off-by: David Goulet <dgoulet@torproject.org>
Signed-off-by: David Goulet <dgoulet@torproject.org>
This approach saves us a pair of curve25519 operations for every subcredential but the first. It is not yet constant-time. I've noted a few places where IMO we should refactor the code so that the complete list of subcredentials is passed in earlier.
Pull Request Test Coverage Report for Build 7839
|
teor2345
reviewed
Feb 3, 2020
| * subcredential in order to validate. */ | ||
| hs_cell_introduce2_data_t new_data = *data; | ||
| /* XXXX This list should have been the descriptor's subcredentials all | ||
| * XXXX along. |
Why is there an XXXX in this comment?
teor2345
reviewed
Feb 3, 2020
| @@ -983,7 +983,10 @@ hs_circ_handle_introduce2(const hs_service_t *service, | |||
| * parsed, decrypted and key material computed correctly. */ | |||
| data.auth_pk = &ip->auth_key_kp.pubkey; | |||
| data.enc_kp = &ip->enc_key_kp; | |||
| data.subcredential = subcredential; | |||
| // XXXX We should replace these elements with something precomputed for | |||
| // XXXX the onionbalance case. | |||
Why is there an XXXX in this comment?
teor2345
reviewed
Feb 3, 2020
| * | ||
| * \details | ||
| * | ||
| * XXX: |
Please document.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
No description provided.
The text was updated successfully, but these errors were encountered: