[Tor Trac #32614]: Flag a v3 intro point as bad if rendezvous fails during cleanup #1682
Conversation
Pull Request Test Coverage Report for Build 8224
|
asn-d6
reviewed
Jun 30, 2020
| safe_str_client(ed25519_fmt(&orig_circ->hs_ident->identity_pk)), | ||
| safe_str_client(build_state_get_exit_nickname( | ||
| orig_circ->build_state))); | ||
| hs_cache_client_intro_state_note(&orig_circ->hs_ident->identity_pk, |
Is indentation right here?
asn-d6
reviewed
Jun 30, 2020
| @@ -1752,6 +1752,7 @@ hs_client_circuit_cleanup_on_free(const circuit_t *circ) | |||
| (circ->marked_for_close_orig_reason == END_CIRC_REASON_TIMEOUT); | |||
| if (has_timed_out) { | |||
| failure = INTRO_POINT_FAILURE_TIMEOUT; | |||
| orig_circ->hs_ident->num_tries += 1; | |||
Should this counter be on the rendezvous circuit or the introduction circuit?
asn-d6
reviewed
Jun 30, 2020
| @@ -0,0 +1,6 @@ | |||
| o Major bugfixes (onion service): | |||
| - If an rendevous point fails multiple times, we mark the intro point | |||
Changes file should mention that the fail should be "time-out" related.
Also, "Previously, we kept rendezvous points even if they failed open", do you mean to say "intro points"?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Ticket: https://trac.torproject.org/projects/tor/ticket/32614
The text was updated successfully, but these errors were encountered: