Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use print() function in both Python 2 and Python 3 #1687

Merged
merged 1 commit into from Jan 30, 2020

Conversation

Labels
None yet
Projects
None yet
4 participants
@cclauss
Copy link
Contributor

@cclauss cclauss commented Jan 28, 2020

A partial solution to https://trac.torproject.org/projects/tor/ticket/32791

Legacy print statements are syntax errors in Python 3 but print() function works as expected in both Python 2 and Python 3.

xrange() was removed in Python 3 in favour of an iterator-base version of range().

@coveralls
Copy link

@coveralls coveralls commented Jan 28, 2020

Pull Request Test Coverage Report for Build 7885

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 63.391%

Totals Coverage Status
Change from base Build 7876: 0.02%
Covered Lines: 49994
Relevant Lines: 78866

💛 - Coveralls

@teor2345
Copy link
Contributor

@teor2345 teor2345 commented Jan 28, 2020

Thanks for this PR.

We track reviews using our Trac ticket system, and we don't always notice GitHub PRs straight away.

If you put a link to the PR on the ticket (or open a new ticket in Core Tor/Tor), and put the ticket in needs_review, then we'll review your PR in the next week or two.

I've put the link for this PR here:
https://trac.torproject.org/projects/tor/ticket/32791#comment:2

@torproject-pusher torproject-pusher merged commit 3208a74 into torproject:master Jan 30, 2020
2 checks passed
@cclauss cclauss deleted the print_function branch Jan 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment