Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ticket33091 #1692

Merged
3 commits merged into from Jan 30, 2020
Merged

Ticket33091 #1692

3 commits merged into from Jan 30, 2020

Conversation

teor2345
Copy link
Contributor

No description provided.

Improve the function comments on connection_finished_connecting(),
to describe what the function actually does.

Part of 33091.
Simplify ip_address_changed() by removing redundant checks
(all exits are relays, and need to rebuild their descriptor when their
IP addresses change).

Rewrite the function comment, and rename the argument, so the function
is easier to understand and use.

Closes 33091.
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7898

  • 2 of 3 (66.67%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 63.39%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/core/mainloop/mainloop.c 2 3 66.67%
Totals Coverage Status
Change from base Build 7892: 0.02%
Covered Lines: 49991
Relevant Lines: 78863

💛 - Coveralls

@ghost ghost merged commit f3ecf0b into torproject:master Jan 30, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants