Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not set "once" when calling tor_bug_occurred_ from BUG(). #1697

Open
wants to merge 1 commit into
base: maint-0.4.1
Choose a base branch
from

Conversation

Labels
None yet
Projects
None yet
2 participants
@nmathewson
Copy link
Contributor

@nmathewson nmathewson commented Jan 30, 2020

The "once" flag makes tor_bug_occurred_() say that future instances
of the warning will be suppressed -- but that's not something that
BUG() does. Fixes bug 33095; bugfix on 0.4.1.1-alpha.

The "once" flag makes tor_bug_occurred_() say that future instances
of the warning will be suppressed -- but that's not something that
BUG() does.  Fixes bug 33095; bugfix on 0.4.1.1-alpha.
@coveralls
Copy link

@coveralls coveralls commented Jan 30, 2020

Pull Request Test Coverage Report for Build 7921

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 13 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.02%) to 61.554%

Files with Coverage Reduction New Missed Lines %
src/feature/dirauth/shared_random.c 4 85.0%
src/feature/dirauth/dirvote.c 9 64.61%
Totals Coverage Status
Change from base Build 7914: -0.02%
Covered Lines: 47458
Relevant Lines: 77100

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment