Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#32928#32929:Tor Manual: Added New sections for Timeout and Node Options #1702

Merged
merged 5 commits into from Feb 10, 2020

Conversation

Labels
None yet
Projects
None yet
5 participants
@swati-thacker13
Copy link
Contributor

@swati-thacker13 swati-thacker13 commented Jan 31, 2020

  • Created new sections for Timeout and Node Options as discussed in https://trac.torproject.org/projects/tor/ticket/32846#comment:11.

  • Moved 7 options from the Client Options section to the new Timeout Options section.

  • Moved 9 options from the Client Options section to the new Advanced Options section. Note that the new *Nodes section is called Advanced Options as discussed in the ticket referenced above.

  • Does the NodeFamily option belong to the new Advanced Options section? I haven't moved it yet because I wanted to check before moving it.

@coveralls
Copy link

@coveralls coveralls commented Jan 31, 2020

Pull Request Test Coverage Report for Build 7989

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 134 unchanged lines in 5 files lost coverage.
  • Overall coverage increased (+0.02%) to 63.396%

Files with Coverage Reduction New Missed Lines %
src/feature/hs/hs_common.c 1 84.27%
src/lib/net/address.h 2 89.47%
src/feature/hs/hs_cache.c 7 93.42%
src/feature/control/control_getinfo.c 8 29.09%
src/feature/hs/hs_client.c 116 55.87%
Totals Coverage Status
Change from base Build 7944: 0.02%
Covered Lines: 50009
Relevant Lines: 78884

💛 - Coveralls

@swati-thacker13 swati-thacker13 requested review from teor2345 and tlyu Feb 3, 2020
@teor2345 teor2345 removed their request for review Feb 3, 2020
@teor2345
Copy link
Contributor

@teor2345 teor2345 commented Feb 3, 2020

Hi, I'm busy with Sponsor 55 right now, can you find someone else to review?

@swati-thacker13 swati-thacker13 requested a review from nmathewson Feb 7, 2020
@swati-thacker13
Copy link
Contributor Author

@swati-thacker13 swati-thacker13 commented Feb 7, 2020

Both tickets #32928 and #32929 have been implemented. Please merge this PR.

@tlyu tlyu mentioned this pull request Feb 7, 2020
@torproject-pusher torproject-pusher merged commit 305934c into torproject:master Feb 10, 2020
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment