Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused import UserDict #1703

Merged
merged 1 commit into from Feb 5, 2020
Merged

Remove unused import UserDict #1703

merged 1 commit into from Feb 5, 2020

Conversation

Reviewers

@teor2345 teor2345

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@cclauss @coveralls @teor2345 @torproject-pusher
@cclauss
Copy link
Contributor

@cclauss cclauss commented Feb 3, 2020 •
edited

Fixes: https://trac.torproject.org/projects/tor/ticket/32791#comment:3
Unblocks: #1686

flake8 --select=F401 will also find seven other unused imports.
@cclauss
Remove unused import UserDict
472d583 
Fixes: https://trac.torproject.org/projects/tor/ticket/32791#comment:3
Unblocks: torproject#1686
@cclauss cclauss requested a review from teor2345 Feb 3, 2020
@coveralls
Copy link

@coveralls coveralls commented Feb 3, 2020

Pull Request Test Coverage Report for Build 7954

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 63.373%
Totals Coverage Status
Change from base Build 7944: 0.0%
Covered Lines: 49978
Relevant Lines: 78863
💛 - Coveralls

@teor2345
Copy link
Contributor

@teor2345 teor2345 commented Feb 5, 2020

Thanks, I've updated the trac ticket:
https://trac.torproject.org/projects/tor/ticket/32791

Someone should merge this PR soon.

@torproject-pusher torproject-pusher merged commit 472d583 into torproject:master Feb 5, 2020
2 checks passed
@cclauss cclauss deleted the patch-3 branch Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment