Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop assuming that /usr/bin/python exists #1712

Closed
wants to merge 1 commit into from
Closed

Stop assuming that /usr/bin/python exists #1712

wants to merge 1 commit into from

Conversation

Labels
None yet
Projects
None yet
3 participants
@panos
Copy link
Contributor

@panos panos commented Feb 7, 2020

This proposed change will change all occasions of /usr/bin/python to the more agnostic /usr/bin/env python, similarly to the change here.

Relevant Trac ticket

@coveralls
Copy link

@coveralls coveralls commented Feb 7, 2020

Pull Request Test Coverage Report for Build 7994

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 63.397%

Totals Coverage Status
Change from base Build 7980: 0.02%
Covered Lines: 50010
Relevant Lines: 78884

💛 - Coveralls

@panos
Copy link
Contributor Author

@panos panos commented Feb 7, 2020

I force-pushed a new commit, after the previous CI check failed, due to me using a # before the ticket number in the commit message.

EDIT: I forgot to make a similar change to the changelog, which also had the same issue.

@panos panos requested a review from nmathewson Feb 8, 2020
@panos
Copy link
Contributor Author

@panos panos commented Feb 9, 2020

I tested and looked into more files in order to figure out which ones should use Python 2, which ones should use Python 3 and which ones should be considered as version agnostic.

@teor2345
Copy link
Contributor

@teor2345 teor2345 commented Feb 10, 2020

Thanks!

Let us know when you've got things working. You might find some of the changes in #1686 helpful.

@panos
Copy link
Contributor Author

@panos panos commented Feb 10, 2020

Thanks!

Let us know when you've got things working. You might find some of the changes in #1686 helpful.

The only problem that I can really think of right now is the tree thing/merge conflict.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment