Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug33087 043 #1723

Merged
merged 7 commits into from Apr 9, 2020
Merged

Bug33087 043 #1723

merged 7 commits into from Apr 9, 2020

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@teor2345 @coveralls @torproject-pusher
@teor2345
Copy link
Contributor

@teor2345 teor2345 commented Feb 12, 2020

No description provided.

@coveralls
Copy link

@coveralls coveralls commented Feb 12, 2020 •
edited

Pull Request Test Coverage Report for Build 8088

  • 9 of 13 (69.23%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.002%) to 63.417%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/lib/err/torerr.c 2 3 66.67%
src/lib/log/util_bug.c 0 1 0.0%
src/lib/log/log.c 6 8 75.0%
Totals Coverage Status
Change from base Build 8059: -0.002%
Covered Lines: 50015
Relevant Lines: 78867
💛 - Coveralls

teor2345 added 3 commits Feb 12, 2020
@teor2345
err/log: Stop closing stderr and stdout during shutdown
c8242e4 
Closing these file descriptors can hide sanitiser logs.

Fixes bug 33087; bugfix on 0.4.1.6.
@teor2345
Merge branch 'maint-0.4.1' into bug33087_041
2c0dfb0
@teor2345
Merge branch 'bug33087_041' into bug33087_042
b6d1f99
teor2345 added 3 commits Feb 12, 2020
@teor2345
err/log: Stop closing stderr and stdout during shutdown
3d1ef3b 
Closing these file descriptors can hide sanitiser logs.

Instead, flush the logs before tor exits, using fsync().
Some Windows environments don't have fsync(), so we check
for it at compile time.

Fixes bug 33087; bugfix on 0.4.1.6.
@teor2345
log: Stop duplicating error file fds
8a23393 
Since we're not closing these fds, they don't need to be duplicated
any more.

Cleanup after 33087.
@teor2345
Merge branch 'bug33087_042' into bug33087_043
4f533ed 
"ours" merge, because the 0.4.2 backport deletes the close
functions. But the 0.4.3 bug fix replaces them with fsync()
where available.
@teor2345
Run "make autostyle"
e849881 
But only take the changes that were caused by the rest of the 33087
branch.

Part of 33087.
@torproject-pusher torproject-pusher merged commit c2aea61 into torproject:maint-0.4.3 Apr 9, 2020
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment