Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ticket33316 #1738

Closed
wants to merge 9 commits into from
Closed

Ticket33316 #1738

wants to merge 9 commits into from

Conversation

Reviewers

@tlyu tlyu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@nmathewson @coveralls @tlyu @torproject-pusher
@nmathewson
Copy link
Contributor

@nmathewson nmathewson commented Feb 13, 2020

No description provided.

nmathewson added 5 commits Feb 13, 2020
@nmathewson
Re-order most subsystems to correspond to dependency order.
67d59d7
@nmathewson
Re-order thread initialization to follow logging, and remove a comment.
691d271 
lib/log no longer uses lib/thread; lib/log only uses lib/lock, which
is at a lower level.
@nmathewson
Move winprocess_sys into a new low-level hardening module
4066097 
This code was in our process module, but it doesn't belong there:
process is for launching and monitoring subprocesses, not for
hardening the current process.

This change lets us have our subsystem init order more closely match
our dependency order.
@nmathewson
Changes file for ticket 33316
e1bcee0
@nmathewson
Initialize all subsystems during the unit tests
3b5f836 
Previously we had initialized only the library subsystems.  This
made it hard to write some tests, and encouraged people to put their
subsystems at a level lower than they really belonged at.  Instead,
it probably just makes sense to initialize everything before we
start the tests.

Without this fix, 33316 breaks our tests because of raising the
level of the ocirc/orconn events.
@coveralls
Copy link

@coveralls coveralls commented Feb 13, 2020 •
edited

Pull Request Test Coverage Report for Build 8192

  • 5 of 7 (71.43%) changed or added relevant lines in 1 file are covered.
  • 3700 unchanged lines in 18 files lost coverage.
  • Overall coverage increased (+0.06%) to 63.471%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/core/or/or_sys.c 5 7 71.43%
Files with Coverage Reduction New Missed Lines %
src/feature/hs/hs_common.c 1 84.27%
src/app/main/shutdown.c 3 73.91%
src/app/main/subsysmgr.c 3 84.09%
src/core/or/scheduler_kist.c 9 79.76%
src/core/or/scheduler.c 12 84.44%
src/feature/dirauth/dirauth_config.c 22 80.29%
src/feature/nodelist/dirlist.c 32 78.29%
src/feature/client/transports.c 42 52.88%
src/feature/dircache/dircache.c 54 70.4%
src/feature/client/addressmap.c 77 60.78%
Totals Coverage Status
Change from base Build 8099: 0.06%
Covered Lines: 50091
Relevant Lines: 78919
💛 - Coveralls

nmathewson added 2 commits Feb 14, 2020
@nmathewson
Merge ocirc and orconn events into or subsystem.
69d1e96 
Pubsub events are not supposed to have their own subsystems; they're
supposed to be part of a parent subsystem.
@nmathewson
Move process subsystem after evloop.
0b242d7 
Process uses evloop, and so should be initialized after it.
tlyu
tlyu reviewed Feb 21, 2020
View changes
src/lib/llharden/.may_include Outdated
@@ -0,0 +1,3 @@
lib/llharden/*.h
lib/subsys/*.h
orconfig.h
Copy link
Contributor

@tlyu tlyu Feb 21, 2020

Missing newline at EOF

nmathewson added 2 commits Feb 21, 2020
@nmathewson
fixup! Move winprocess_sys into a new low-level hardening module
add7e84 
Add a missing newline at EOF.
@nmathewson
extend ticket33316 changes file to include more changes
5d051a8
@torproject-pusher torproject-pusher deleted the branch torproject:master May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment