Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ticket33334 #1744

Merged
merged 5 commits into from Feb 19, 2020
Merged

Ticket33334 #1744

merged 5 commits into from Feb 19, 2020

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@teor2345 @coveralls @torproject-pusher
@teor2345
Copy link
Contributor

@teor2345 teor2345 commented Feb 17, 2020

No description provided.

teor2345 added 3 commits Feb 17, 2020
@teor2345
Makefile: Refactor and tweak test-network
2151822 
The refactor is simpler, and supports IPv6 mixed networks.

The refactor also slightly changes the order of the IPv6 and mixed
checks. But it's closer to the original order before 33280.

And if all the network lists that need a network type are empty,
we don't check if we can run that network type. (And if a network
list is empty, we don't say we're going to run an empty list.)

Part of 33334.
@teor2345
Makefile: Add v3 onion services to the mixed network
85eb170 
This network is used in make test-network-all and test-network-ipv4.

Part of 33334.
@teor2345
Makefile: Add an IPv6 mixed chutney network
da280a4 
This network is used in make test-network-all and test-network-ipv6.

Closes 33334.
@coveralls
Copy link

@coveralls coveralls commented Feb 17, 2020 •
edited

Pull Request Test Coverage Report for Build 8155

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 22 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.008%) to 63.432%
Files with Coverage Reduction New Missed Lines %
src/feature/dirauth/shared_random.c 1 85.71%
src/core/or/scheduler_kist.c 9 79.76%
src/core/or/scheduler.c 12 84.44%
Totals Coverage Status
Change from base Build 8127: 0.008%
Covered Lines: 50037
Relevant Lines: 78883
💛 - Coveralls

@teor2345
Makefile: Silence some submake logs in test-network
aebae82 
These logs split up the chutney SKIP, PASS, and FAIL messages,
and they don't actually contain any useful information.

Cleanup after 33334.
@teor2345
Copy link
Contributor Author

@teor2345 teor2345 commented Feb 18, 2020

Looks like Travis passed here, but the CI is still shown as pending.

@teor2345
Makefile: Tweak the test-network* chuttney networks
6e76570 
In "make test-network", add tests for single onion services v2 and v3.

In "make test-network-all", test onion services v2 and v3 in the same
network.

Part of 33334.
@torproject-pusher torproject-pusher merged commit 6e76570 into torproject:master Feb 19, 2020
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment