Bug4631 #1747
Closed
Bug4631 #1747
Conversation
If we receive via 'post' a vote from a dir auth after the
fetch_missing_votes cutoff, that means we didn't get it by the time we
begin the "fetching missing votes from everybody else" phase, which means
it is very likely to cause a consensus split if we count it. Instead,
we reject it.
But we still allow votes that we fetch ourselves after that cutoff.
This is a demo branch for making progress on #4631.
I've been running it on moria1 and it catches and handles real buggy
behavior from directory authorities, e.g.
Jan 28 15:59:50.804 [warn] Rejecting vote from 199.58.81.140 received at 2020-01-28 20:59:50; our cutoff for received votes is 2020-01-28 20:52:30
Jan 28 15:59:50.805 [warn] Rejected vote from 199.58.81.140 ("Vote received too late, would be dangerous to count it").
Jan 29 01:52:52.667 [warn] Rejecting vote from 204.13.164.118 received at 2020-01-29 06:52:52; our cutoff for received votes is 2020-01-29 06:52:30
Jan 29 01:52:52.669 [warn] Rejected vote from 204.13.164.118 ("Vote received too late, would be dangerous to count it").
Jan 29 04:53:26.323 [warn] Rejecting vote from 204.13.164.118 received at 2020-01-29 09:53:26; our cutoff for received votes is 2020-01-29 09:52:30
Jan 29 04:53:26.326 [warn] Rejected vote from 204.13.164.118 ("Vote received too late, would be dangerous to count it").
Part of 4631.
Part of 4631.
Refactor dirvote_add_vote() by splitting some code out into static functions. Cleanup after 4631.
Update the function that handles directory authority votes when the dirauth module is disabled. Part of 4631.
Pull Request Test Coverage Report for Build 8160
|
nmathewson
reviewed
Feb 18, 2020
src/feature/dirauth/dirvote.c
Outdated
| @@ -3200,6 +3201,25 @@ dirvote_add_vote(const char *vote_body, const char **msg_out, int *status_out) | |||
| goto err; | |||
| } | |||
|
|
|||
| if (!time_posted) { /* I imported this one myself */ | |||
| log_notice(LD_DIR, "Retrieved vote from %s.", vi->address); | |||
Should we be logging this in all cases where we don't reject the vote?
I don't think this log is correct. The vote is either downloaded from another authority, or loaded from disk. The comment "imported" conflicts with the log message "Retrieved", and neither cover both cases.
And I don't think it's helpful to log a notice, we already log lots of info about votes.
I removed it in 15192f8.
nmathewson
reviewed
Feb 18, 2020
src/feature/dirauth/dirvote.c
Outdated
| format_iso_time(tbuf2, voting_schedule.fetch_missing_votes); | ||
| log_warn(LD_DIR, "Rejecting vote from %s received at %s; " | ||
| "our cutoff for received votes is %s", vi->address, tbuf1, tbuf2); | ||
| *msg_out = "Vote received too late, would be dangerous to count it"; |
Should this be a more actionable warning? It could suggest checking your clock is skewed, and checking whether your CPU is hosed. If neither of those is true, then we have a bug somewhere.
Here are the different possible causes:
- skewed clock
- CPU load
- network load
Late votes can be caused by these issues on the local or remote authority.
I edited the log message in d8c719e.
Cleanup after 4631.
Cleanup after 4631.
|
squashed and merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
No description provided.
The text was updated successfully, but these errors were encountered: