Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract routerkeys #1758

Closed
wants to merge 4 commits into from
Closed

Extract routerkeys #1758

wants to merge 4 commits into from

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@nmathewson @coveralls @torproject-pusher
@nmathewson
Copy link
Contributor

@nmathewson nmathewson commented Feb 20, 2020

No description provided.

nmathewson added 3 commits Feb 20, 2020
@nmathewson
Extract relay-only handshake code into its own file.
dd4fa9b 
This is not the only relay-only handshake code, but it is most of
such code that is in connection_or.c.
@nmathewson
Disable routerkeys.c with --disable-relay-mode.
5202f77
@nmathewson
Move relay_handshake.[ch] into src/feature/relay, and make it optional
e693688
@coveralls
Copy link

@coveralls coveralls commented Feb 20, 2020 •
edited

Pull Request Test Coverage Report for Build 8174

  • 206 of 225 (91.56%) changed or added relevant lines in 1 file are covered.
  • 1431 unchanged lines in 6 files lost coverage.
  • Overall coverage increased (+0.06%) to 63.472%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/feature/relay/relay_handshake.c 206 225 91.56%
Files with Coverage Reduction New Missed Lines %
src/feature/dirauth/dirauth_config.c 22 80.29%
src/feature/nodelist/dirlist.c 32 78.29%
src/feature/dircache/dircache.c 54 70.4%
src/feature/nodelist/nodelist.c 233 71.64%
src/feature/dirauth/dirvote.c 303 65.41%
src/core/mainloop/connection.c 787 27.81%
Totals Coverage Status
Change from base Build 8168: 0.06%
Covered Lines: 50087
Relevant Lines: 78912
💛 - Coveralls

@nmathewson nmathewson force-pushed the extract_routerkeys branch from ab708cf to e693688 Feb 20, 2020
@nmathewson
fixup! Disable routerkeys.c with --disable-relay-mode.
d2fbb25
@torproject-pusher torproject-pusher deleted the branch torproject:master May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment