Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hs-v3: Log reasons why service can't upload descriptor #1760

Closed
wants to merge 2 commits into from
Closed

hs-v3: Log reasons why service can't upload descriptor #1760

wants to merge 2 commits into from

Conversation

Reviewers

@asn-d6 asn-d6

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@dgoulet-tor @coveralls @asn-d6 @torproject-pusher
@dgoulet-tor
Copy link
Contributor

@dgoulet-tor dgoulet-tor commented Feb 20, 2020

When a service can not upload its descriptor(s), we have no logs on why. This
adds logging for each possible reason for each descriptors.

That logging is emitted every second so it is rate limited for each reason and
per descriptor.

Closes #33400

Signed-off-by: David Goulet dgoulet@torproject.org
@coveralls
Copy link

@coveralls coveralls commented Feb 20, 2020 •
edited

Pull Request Test Coverage Report for Build 8293

  • 27 of 27 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 63.862%
Totals Coverage Status
Change from base Build 8286: 0.02%
Covered Lines: 50562
Relevant Lines: 79174
💛 - Coveralls

asn-d6
asn-d6 requested changes Feb 26, 2020
View changes
src/feature/hs/hs_service.c Outdated Show resolved Hide resolved
src/feature/hs/hs_service.c Outdated Show resolved Hide resolved
src/feature/hs/hs_service.c Outdated Show resolved Hide resolved
src/test/test_hs_service.c Show resolved Hide resolved
@dgoulet-tor
hs-v3: Log reasons why service can't upload descriptor
522185a 
When a service can not upload its descriptor(s), we have no logs on why. This
adds logging for each possible reason for each descriptors.

That logging is emitted every second so it is rate limited for each reason and
per descriptor.

Closes #33400

Signed-off-by: David Goulet <dgoulet@torproject.org>
@dgoulet-tor dgoulet-tor force-pushed the ticket33400_044_01 branch from 6baa2f3 to 522185a Mar 10, 2020
@dgoulet-tor
fixup! hs-v3: Log reasons why service can't upload descriptor
e23ac36
@torproject-pusher torproject-pusher deleted the branch torproject:master May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment