Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ticket33460 043 #1765

Merged
merged 4 commits into from Mar 5, 2020
Merged

Ticket33460 043 #1765

merged 4 commits into from Mar 5, 2020

Conversation

Reviewers

@tlyu tlyu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@nmathewson @coveralls @tlyu @torproject-pusher
@nmathewson
Copy link
Contributor

@nmathewson nmathewson commented Feb 26, 2020

No description provided.

nmathewson added 4 commits Feb 26, 2020
@nmathewson
confmgt: when an int/enum value is invalid, say which values are ok.
b133325 
Part of 33460.
@nmathewson
confmgt: when a units value is invalid, include a meaningful error.
7e7aff9 
Part of 33460.
@nmathewson
In typed_var_kvassign, include config names in error messages.
2c792d1 
This should improve the usability of our configuration error messages.
@nmathewson
changes file for ticket 33460.
87e0873
@coveralls
Copy link

@coveralls coveralls commented Feb 26, 2020

Pull Request Test Coverage Report for Build 8212

  • 44 of 47 (93.62%) changed or added relevant lines in 3 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.02%) to 63.847%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/lib/confmgt/unitparse.c 16 17 94.12%
src/lib/confmgt/type_defs.c 23 25 92.0%
Files with Coverage Reduction New Missed Lines %
src/core/or/or.h 1 88.89%
src/lib/net/address.h 2 73.33%
Totals Coverage Status
Change from base Build 8202: 0.02%
Covered Lines: 50520
Relevant Lines: 79127
💛 - Coveralls

tlyu
tlyu reviewed Mar 4, 2020
View changes
src/lib/confmgt/typedvar.c
int rv = typed_var_assign(target, line->value, errmsg, def);
if (rv < 0 && *errmsg != NULL) {
/* typed_var_assign() didn't know the line's keyword, but we do.
* Let's add it to the error message. */
Copy link
Contributor

@tlyu tlyu Mar 4, 2020

This seems like it's working around a design limitation in the existing code. I'm afraid I don't have a good alternative at the moment, though.

@torproject-pusher torproject-pusher merged commit 7177eed into torproject:master Mar 5, 2020
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment