Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hs-v3: Don't close intro circuit for an encrypted descriptor #1782

Open
wants to merge 2 commits into
base: maint-0.4.3
Choose a base branch
from

Conversation

Labels
None yet
Projects
None yet
2 participants
@dgoulet-tor
Copy link
Contributor

@dgoulet-tor dgoulet-tor commented Mar 10, 2020

To close intro circuits, we need a valid decrypted descriptor in order to find
the circuit by authentication key. However, we can have encrypted descriptors
in the client cache that are waiting for a client authorization token.

This commit doesn't attempt to close intro circuits for that situation because
we are unable to access the authentication key for each intro circuit.

Signed-off-by: David Goulet dgoulet@torproject.org

To close intro circuits, we need a valid decrypted descriptor in order to find
the circuit by authentication key. However, we can have encrypted descriptors
in the client cache that are waiting for a client authorization token.

This commit doesn't attempt to close intro circuits for that situation because
we are unable to access the authentication key for each intro circuit.

Signed-off-by: David Goulet <dgoulet@torproject.org>
@coveralls
Copy link

@coveralls coveralls commented Mar 10, 2020

Pull Request Test Coverage Report for Build 8303

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.0008%) to 63.466%

Files with Coverage Reduction New Missed Lines %
src/feature/hs/hs_common.c 1 84.27%
Totals Coverage Status
Change from base Build 8281: -0.0008%
Covered Lines: 50089
Relevant Lines: 78922

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment