Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hs-v3: Improve accessor semantic of client cached object #1783

Closed
wants to merge 2 commits into from
Closed

hs-v3: Improve accessor semantic of client cached object #1783

wants to merge 2 commits into from

Conversation

Reviewers

@asn-d6 asn-d6

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@dgoulet-tor @coveralls @asn-d6 @torproject-pusher
@dgoulet-tor
Copy link
Contributor

@dgoulet-tor dgoulet-tor commented Mar 10, 2020

Add an inline helper function that indicates if the cached object contains a
decrypted descriptor or not.

The descriptor object is NULL if tor is unable to decrypt it (lacking client
authorization) and some actions need to be done only when we have a decrypted
object.

This improves code semantic.

Fixes #33458

Signed-off-by: David Goulet dgoulet@torproject.org
@dgoulet-tor
hs-v3: Improve accessor semantic of client cached object
10b17fe 
Add an inline helper function that indicates if the cached object contains a
decrypted descriptor or not.

The descriptor object is NULL if tor is unable to decrypt it (lacking client
authorization) and some actions need to be done only when we have a decrypted
object.

This improves code semantic.

Fixes #33458

Signed-off-by: David Goulet <dgoulet@torproject.org>
@coveralls
Copy link

@coveralls coveralls commented Mar 10, 2020 •
edited

Pull Request Test Coverage Report for Build 8302

  • 19 of 19 (100.0%) changed or added relevant lines in 1 file are covered.
  • 119 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.03%) to 63.868%
Files with Coverage Reduction New Missed Lines %
src/feature/hs/hs_common.c 1 84.48%
src/feature/hs/hs_service.c 118 74.26%
Totals Coverage Status
Change from base Build 8286: 0.03%
Covered Lines: 50575
Relevant Lines: 79187
💛 - Coveralls

asn-d6
asn-d6 requested changes Mar 10, 2020
View changes
src/feature/hs/hs_cache.c Show resolved Hide resolved
src/feature/hs/hs_cache.c Outdated Show resolved Hide resolved
src/feature/hs/hs_cache.c Show resolved Hide resolved
@dgoulet-tor
fixup! hs-v3: Improve accessor semantic of client cached object
8aa2d05
@torproject-pusher torproject-pusher deleted the branch torproject:master May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment