hs-v3: Relax severity of a log message when decoding descriptors. #1791
Conversation
Make it LOG_PROTOCOL_WARN and also add the expiration timestamp in there to ease debugging in the future.
dgoulet-tor
reviewed
Mar 11, 2020
| expiration_str); | ||
| } else { | ||
| log_warn(LD_REND, "Invalid signature for %s: %s", | ||
| log_obj_type, tor_cert_describe_signature_status(cert)); |
Wasn't the idea of the ticket to make this one proto warn? Because anyone can trigger that remotely or can they with your patch?
It's true that people can trigger this remotely, but so is the case for hundreds of Tor's logs. AFAIK only the expiration case of this message is actually getting frequently triggered and that's why I only tried to hide that (and also add some more information for debugging).
I thought that by allowing the other messages get past, we might find a bug or something at some point.
Let me know and I can put everything at log proto warn.
Pull Request Test Coverage Report for Build 8314
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Make it LOG_PROTOCOL_WARN and also add the expiration timestamp in there to
ease debugging in the future.
The text was updated successfully, but these errors were encountered: