Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ticket32994 squashed #1797

Merged
merged 2 commits into from Mar 23, 2020
Merged

Ticket32994 squashed #1797

merged 2 commits into from Mar 23, 2020

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@teor2345 @coveralls @torproject-pusher @Suraj-Upadhyay
@teor2345
Copy link
Contributor

@teor2345 teor2345 commented Mar 14, 2020

No description provided.

Suraj-Upadhyay and others added 2 commits Mar 14, 2020
@Suraj-Upadhyay @teor2345
Get all default flags from port_cfg_new()
1a9cbc5 
Now port_cfg_new() returns all default flags and
port_parse_config() acts on defaults returned by port_cfg_new()
that is uses the default port_cfg_t object returned by port_cfg_new()
and modifies them later according to the port specifications in
configuration files
Might close tor#32994.
@teor2345
changes: Fix style of changes file for 32994
384111c
@teor2345 teor2345 mentioned this pull request Mar 14, 2020
Closed
@teor2345 teor2345 mentioned this pull request Mar 14, 2020
Closed
@coveralls
Copy link

@coveralls coveralls commented Mar 14, 2020

Pull Request Test Coverage Report for Build 8368

  • 43 of 44 (97.73%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.009%) to 63.88%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/app/config/config.c 43 44 97.73%
Files with Coverage Reduction New Missed Lines %
src/app/config/config.c 2 79.85%
Totals Coverage Status
Change from base Build 8357: 0.009%
Covered Lines: 50565
Relevant Lines: 79156
💛 - Coveralls

@torproject-pusher torproject-pusher merged commit a0efba9 into torproject:master Mar 23, 2020
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment