Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug32588 035 tests #1826

Closed
wants to merge 10 commits into from
Closed

Bug32588 035 tests #1826

wants to merge 10 commits into from

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@teor2345 @coveralls @nmathewson
@teor2345
Copy link
Contributor

@teor2345 teor2345 commented Mar 20, 2020

No description provided.

teor2345 and others added 10 commits Jan 13, 2020
@teor2345
router: Stop advertising incorrect auto IPv6 ORPorts
43452b4 
When IPv6 ORPorts are set to "auto", tor relays and bridges would
advertise an incorrect port in their descriptor.

This may be a low-severity memory safety issue, because the published
port number may be derived from uninitialised or out-of-bounds memory
reads.

Fixes bug 32588; bugfix on 0.2.3.9-alpha.
@teor2345
router: Refactor IPv6 ORPort function logic
ab9078e 
Return early when there is no suitable IPv6 ORPort.
Show the address and port on error, using a convenience function.

Code simplification and refactoring.

Cleanup after 32588.
@nmathewson
Add tests for get_first_advertised_{addr,port}_by_type_af()
29af708
@nmathewson
Add a test for router_get_advertised_or_port_by_af().
704507f
@nmathewson
Extend test to handle router_get_advertised_ipv6_or_ap
189c7fa
@nmathewson
Add a test for the localhost case.
5607225
@teor2345
test/config: Add an extra advertised IPv6 test
9a852f5 
Part of 32588.
@teor2345
test/router: Add extra router_get_advertised_ipv6_or_ap tests
0630859 
And make sure that the IPv6 tests cover the original 32588 bug.

Part of 32588.
@teor2345
test/router: Add extra localhost advertised port tests
0cb8753 
Part of 32588.
@teor2345
fixup! router: Stop advertising incorrect auto IPv6 ORPorts
b0f961d
@coveralls
Copy link

@coveralls coveralls commented Mar 20, 2020

Pull Request Test Coverage Report for Build 8518

  • 13 of 18 (72.22%) changed or added relevant lines in 1 file are covered.
  • 1240 unchanged lines in 37 files lost coverage.
  • Overall coverage decreased (-1.7%) to 59.271%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/feature/relay/router.c 13 18 72.22%
Files with Coverage Reduction New Missed Lines %
src/feature/dirclient/dirclient.c 1 18.5%
src/feature/hs/hs_service.c 1 73.16%
src/feature/nodelist/nodelist.c 1 61.26%
src/core/or/circuitlist.c 2 55.45%
src/core/or/policies.c 2 84.6%
src/ext/tinytest.c 2 49.51%
src/feature/dircache/consdiffmgr.c 2 90.06%
src/feature/nodelist/microdesc.c 2 73.12%
src/feature/relay/router.c 2 36.65%
src/feature/rend/rendcache.c 2 92.89%
Totals Coverage Status
Change from base Build 8488: -1.7%
Covered Lines: 43378
Relevant Lines: 73186
💛 - Coveralls

@teor2345
Copy link
Contributor Author

@teor2345 teor2345 commented Mar 20, 2020

Obsoleted by #1654.

@teor2345 teor2345 closed this Mar 20, 2020
@teor2345 teor2345 deleted the bug32588_035_tests branch Mar 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment