Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug32588 035 #1827

Merged
merged 6 commits into from Oct 7, 2020
Merged

Bug32588 035 #1827

merged 6 commits into from Oct 7, 2020

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@teor2345 @coveralls @torproject-pusher @nmathewson
@teor2345
Copy link
Contributor

@teor2345 teor2345 commented Mar 20, 2020

No description provided.

teor2345 and others added 6 commits Mar 20, 2020
@teor2345
router: Stop advertising incorrect auto IPv6 ORPorts
861337f 
When IPv6 ORPorts are set to "auto", tor relays and bridges would
advertise an incorrect port in their descriptor.

This may be a low-severity memory safety issue, because the published
port number may be derived from uninitialised or out-of-bounds memory
reads.

Fixes bug 32588; bugfix on 0.2.3.9-alpha.
@teor2345
router: Refactor IPv6 ORPort function logic
bac8bc0 
Return early when there is no suitable IPv6 ORPort.
Show the address and port on error, using a convenience function.

Code simplification and refactoring.

Cleanup after 32588.
@nmathewson @teor2345
Add tests for get_first_advertised_{addr,port}_by_type_af()
6ffe073
@nmathewson @teor2345
Add a test for router_get_advertised_or_port_by_af().
1ba79d4
@nmathewson @teor2345
Extend test to handle router_get_advertised_ipv6_or_ap
1251265
@nmathewson @teor2345
Add a test for the localhost case.
96ca14d
@coveralls
Copy link

@coveralls coveralls commented Mar 20, 2020

Pull Request Test Coverage Report for Build 8522

  • 15 of 18 (83.33%) changed or added relevant lines in 1 file are covered.
  • 14 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.02%) to 60.949%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/feature/relay/router.c 15 18 83.33%
Files with Coverage Reduction New Missed Lines %
src/lib/log/log.c 1 74.04%
src/feature/dirauth/shared_random.c 4 85.1%
src/feature/dirauth/dirvote.c 9 64.65%
Totals Coverage Status
Change from base Build 8488: 0.02%
Covered Lines: 44618
Relevant Lines: 73205
💛 - Coveralls

@torproject-pusher torproject-pusher merged commit 741edf1 into torproject:maint-0.3.5 Oct 7, 2020
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment