Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inbufoverflow1 merged #1834

Closed
wants to merge 9 commits into from
Closed

Inbufoverflow1 merged #1834

wants to merge 9 commits into from

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@nmathewson @coveralls @torproject-pusher
@nmathewson
Copy link
Contributor

@nmathewson nmathewson commented Mar 23, 2020

No description provided.

cypherpunks and others added 9 commits Mar 12, 2020
core/mainloop: Limit growth of conn->inbuf
68a951c 
If the buf_t's length could potentially become greater than INT_MAX - 1,
it sets off an IF_BUG_ONCE in buf_read_from_tls().

All of the rest of the buffers.c code has similar BUG/asserts for this
invariant.
buf: add BUF_MAX_LEN
0f2c240
net, tls: use INT_MAX - 1 in checks for buf_t
8ff9ec4 
No functionality change.
buf: use INT_MAX - 1 in checks
0dc9807 
No functionality change.
net, tls: use BUF_MAX_LEN
217559f
buf: use BUF_MAX_LEN
699614c
core/mainloop: remove noisy logging
4cd3aa8
@nmathewson
fix changes file so that "make check-changes" passes
3c196ba
@nmathewson
Merge branch 'inbufoverflow1' into inbufoverflow1_merged
c31f177
@coveralls
Copy link

@coveralls coveralls commented Mar 23, 2020

Pull Request Test Coverage Report for Build 8547

  • 23 of 28 (82.14%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.002%) to 64.049%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/lib/buf/buffers.c 14 15 93.33%
src/lib/tls/buffers_tls.c 3 4 75.0%
src/core/mainloop/connection.c 0 3 0.0%
Totals Coverage Status
Change from base Build 8545: -0.002%
Covered Lines: 50734
Relevant Lines: 79211
💛 - Coveralls

@torproject-pusher torproject-pusher deleted the branch torproject:master May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment