Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug33762 #1844

Merged
merged 2 commits into from Apr 1, 2020
Merged

Bug33762 #1844

merged 2 commits into from Apr 1, 2020

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@asn-d6 @coveralls @torproject-pusher
@asn-d6
Copy link
Member

@asn-d6 asn-d6 commented Mar 30, 2020

No description provided.

asn-d6 added 2 commits Mar 30, 2020
@asn-d6
hs-v3: Don't crash after SIGHUP in Onionbalance backend mode.
0667a5a 
The ob_subcreds array was not copied after SIGHUP, and that left the
post-SIGHUP service with a NULL ob_subcreds pointer (until the next descriptor
gets build where we regenerate ob_subcreds in hs_ob_refresh_keys()).

Fixes bug #33762; not in any released tor version.
@asn-d6
hs-v3: Move ob_subcreds to hs_service_state_t.
8fda94f 
It's more natural there since it's runtime state.
@coveralls
Copy link

@coveralls coveralls commented Mar 30, 2020

Pull Request Test Coverage Report for Build 8600

  • 8 of 14 (57.14%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.003%) to 64.049%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/feature/hs/hs_service.c 1 7 14.29%
Files with Coverage Reduction New Missed Lines %
src/feature/hs/hs_service.c 1 75.54%
Totals Coverage Status
Change from base Build 8596: -0.003%
Covered Lines: 50698
Relevant Lines: 79155
💛 - Coveralls

@torproject-pusher torproject-pusher merged commit b5412d1 into torproject:master Apr 1, 2020
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment