configure: Fix enabled module variable expansion #1847
Closed
Conversation
Fixes #33646 Signed-off-by: David Goulet <dgoulet@torproject.org>
Pull Request Test Coverage Report for Build 8618
|
teor2345
reviewed
Mar 31, 2020
configure.ac
Outdated
| @@ -2665,7 +2665,7 @@ PPRINT_SUBTITLE([Modules]) | |||
|
|
|||
| m4_foreach_w([mname], MODULES, | |||
| [ | |||
| test "xenable_module_mname" != "xno" && value=1 || value=0 | |||
| test "x$enable_module_[]mname[]" != "xno" && value=1 || value=0 | |||
That still doesn't work, all modules should be "no" when relay is disabled:
https://travis-ci.org/github/torproject/tor/jobs/669204177#L2324
Looks like you're using the input variable, rather than the module variable?
Maybe try something like this:
Suggested change
| test "x$enable_module_[]mname[]" != "xno" && value=1 || value=0 | |
| MODULE=m4_toupper([]mname[]) | |
| AM_COND_IF(BUILD_MODULE_[]MODULE[], value=1, value=0) |
|
Squashed and merged to 0.4.3 and later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Fixes #33646
Signed-off-by: David Goulet dgoulet@torproject.org
The text was updated successfully, but these errors were encountered: