Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug34077 044 #1879

Closed
wants to merge 5 commits into from
Closed

Bug34077 044 #1879

wants to merge 5 commits into from

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@nmathewson @coveralls @torproject-pusher
@nmathewson
Copy link
Contributor

@nmathewson nmathewson commented May 1, 2020

No description provided.

nmathewson added 5 commits May 1, 2020
@nmathewson
Fix a GCC 10.0.1 compilation warning.
d7e166b 
Fixes 34077 for 0.4.1; bugfix on 0.4.0.3-alpha. (Specifically, GCC
first gives this warning for 9eeff92)
@nmathewson
Merge branch 'bug34077_041' into bug34077_042
b4b1882
@nmathewson
Merge branch 'bug34077_042' into bug34077_043
6aaee61
@nmathewson
Fix a GCC 10.0.1 compilation error.
b1c383e 
Do not try to stuff "HS_DESC_DECODE_GENERIC_ERROR" (-1) into a
socks5_reply_status_t (enum).  It doesn't actually make sense, and
isn't one of our documented extensions.

(This can only happen on a nonfatal assertion that we haven't seen,
so it probably isn't happening in practice.)

Fixes another case of bug 34077; bugfix on 0.4.3.1-alpha.
@nmathewson
Merge branch 'bug34077_043' into ticket34077_044
747a66e
@coveralls
Copy link

@coveralls coveralls commented May 1, 2020

Pull Request Test Coverage Report for Build 8826

  • 2 of 3 (66.67%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.02%) to 64.213%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/feature/hs/hs_client.c 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
src/feature/hs/hs_common.c 1 84.48%
Totals Coverage Status
Change from base Build 8819: 0.02%
Covered Lines: 50941
Relevant Lines: 79331
💛 - Coveralls

@torproject-pusher torproject-pusher deleted the branch torproject:master May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment