Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ticket33789 044 01 #1880

Merged
merged 4 commits into from May 7, 2020
Merged

Ticket33789 044 01 #1880

merged 4 commits into from May 7, 2020

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@dgoulet-tor @coveralls @torproject-pusher
@dgoulet-tor
Copy link
Contributor

@dgoulet-tor dgoulet-tor commented May 5, 2020

No description provided.

@coveralls
Copy link

@coveralls coveralls commented May 5, 2020 •
edited

Pull Request Test Coverage Report for Build 8845

  • 91 of 122 (74.59%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 64.2%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/app/config/resolve_addr.c 82 84 97.62%
src/feature/relay/relay_find_addr.c 9 38 23.68%
Totals Coverage Status
Change from base Build 8836: 0.002%
Covered Lines: 50929
Relevant Lines: 79329
💛 - Coveralls

dgoulet-tor added 3 commits May 5, 2020
@dgoulet-tor
relay: New file relay_resolve_addr.{c|h}
445df9e 
This commit moves router_pick_published_address() and the related helper
functions into the new file.

The log_addr_has_changed() function has been made public in router.h so we can
use it in relay_resolve_addr.c.

This is a refactoring as part of Sponsor 55. Only code movement at this
commit.

Part of #33789

Signed-off-by: David Goulet <dgoulet@torproject.org>
@dgoulet-tor
config: New file resolve_addr.{c|h}
a25f167 
Move a series of function from config.c into that new file which is related to
address resolving.

Part of #33789

Signed-off-by: David Goulet <dgoulet@torproject.org>
@dgoulet-tor
changes: File for #33789
2e519fb 
Signed-off-by: David Goulet <dgoulet@torproject.org>
@dgoulet-tor dgoulet-tor force-pushed the ticket33789_044_01 branch from d2dfd41 to 2e519fb May 5, 2020
@dgoulet-tor
relay: Rename relay_resolve_addr.{c|h} file
c81c5a2 
New name is more accurate semantically.

Closes #33789

Signed-off-by: David Goulet <dgoulet@torproject.org>
@torproject-pusher torproject-pusher merged commit b7a1652 into torproject:master May 7, 2020
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment