Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tor Trac #24844]: Add HS v3 status to the SIGUSR1 dumpstats() #1898

Closed
wants to merge 6 commits into from
Closed

[Tor Trac #24844]: Add HS v3 status to the SIGUSR1 dumpstats() #1898

wants to merge 6 commits into from

Conversation

Reviewers

@asn-d6 asn-d6

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@neelchauhan @coveralls @asn-d6 @torproject-pusher
@neelchauhan
Copy link
Contributor

@neelchauhan neelchauhan commented May 17, 2020

Ticket: https://trac.torproject.org/projects/tor/ticket/24844
neelchauhan added 2 commits May 17, 2020
@neelchauhan
Add HS v3 status to the SIGUSR1 dumpstats()
112808c
@neelchauhan
Add changes file for ticket #24844
d513a01
@coveralls
Copy link

@coveralls coveralls commented May 17, 2020 •
edited

Pull Request Test Coverage Report for Build 8989

  • 0 of 19 (0.0%) changed or added relevant lines in 2 files are covered.
  • 252 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.02%) to 64.177%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/app/main/main.c 0 1 0.0%
src/feature/hs/hs_service.c 0 18 0.0%
Files with Coverage Reduction New Missed Lines %
src/feature/rend/rendservice.c 18 32.39%
src/feature/control/control_getinfo.c 54 28.67%
src/app/main/main.c 180 22.0%
Totals Coverage Status
Change from base Build 8936: -0.02%
Covered Lines: 50933
Relevant Lines: 79363
💛 - Coveralls

asn-d6
asn-d6 reviewed May 19, 2020
View changes
src/feature/hs/hs_service.c Outdated Show resolved Hide resolved
src/feature/hs/hs_service.c Outdated Show resolved Hide resolved
src/feature/hs/hs_service.c Outdated Show resolved Hide resolved
neelchauhan added 2 commits May 19, 2020
@neelchauhan
fixup! Add HS v3 status to the SIGUSR1 dumpstats()
5780ca2
@neelchauhan
fixup! fixup! Add HS v3 status to the SIGUSR1 dumpstats()
581881d
asn-d6
asn-d6 reviewed May 21, 2020
View changes
src/feature/hs/hs_service.c Outdated
const char *nickname;

intro_node = get_node_from_intro_point(ip);
tor_assert(intro_node);
Copy link
Member

@asn-d6 asn-d6 May 21, 2020

Please don't assert here (or below) and instead do a regular check like you are doing for circ below.

@neelchauhan
fixup! Add HS v3 status to the SIGUSR1 dumpstats()
3597b09
@neelchauhan
fixup! Add HS v3 status to the SIGUSR1 dumpstats()
d4d9a63
@torproject-pusher torproject-pusher deleted the branch torproject:master May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment