Freestyle refactor #191

nmathewson · 2018-06-28T18:45:21Z

No description provided.

This code was in compat_threads, since it was _used_ for efficiently notifying the main libevent thread from another thread. But in spite of its usage, it's fundamentally a part of the network code.

Note that the workqueue code does *not* go here: it is logically at a higher level, since it needs to use libevent and the networking stack.

Note that procmon does *not* go here, since procmon needs to integrate with the event loop.

We need to use lib/fs/winlib.h here so that we can use GetTickCount64. I would love to declare that XP is dead, and everybody has GetTickCount64.

nmathewson added 27 commits Jun 28, 2018

Extract the alert-socket code into lib/net.

544ab27

This code was in compat_threads, since it was _used_ for efficiently notifying the main libevent thread from another thread. But in spite of its usage, it's fundamentally a part of the network code.

Extract threading code into a new library.

9cf335c

Note that the workqueue code does *not* go here: it is logically at a higher level, since it needs to use libevent and the networking stack.

Extract memarea into its own library

eee86e6

Fix up the modules that include memarea.h (automated)

38fd3e0

Move conffile and storagedir to lib/fs

a1f3ece

Fix the include paths for storagedir,conffile (automated)

ec4eee6

Extract process-management functionality into a new lib/process

315e6b5

Note that procmon does *not* go here, since procmon needs to integrate with the event loop.

Move socket-errno code into lib/net

84b8dfe

Move lockfile code into lib/fs

aa3edfd

Move weakrng into lib/intmath

48ebd9b

Move string_is_key_value to lib/encoding

3016626

Move tor_escape_str_for_pt_args into or/transports.c

8c6ff9f

Move tor_gethostname to lib/net

db1a420

Move network_init to lib/net

042df08

Move compute_num_cpus to lib/thread

6178a9f

Move floating-point math functions into a new lib/math

bdea94a

Extract time functionality into lib/wallclock and lib/time

a097ddb

Fix up the include path of compat_time.h (automated)

57f4b83

Remove a pair of windows flags used nowhere in our code

8736892

Move MIN and MAX into lib/intmath/cmp.h

3d1e99d

Update lib/compress to not require common/*.h

4dda026

Add ntohs and htons to lib/arch/bytes.h

8fc15e4

Move DLL support to lib/fs

02bb701

fixup! Extract time functionality into lib/wallclock and lib/time

326c473

Use tor_ntohs in compress.c; avoid a winsocks dependency

7d7af19

Fix windows compilation in compat_time

0f02d2c

We need to use lib/fs/winlib.h here so that we can use GetTickCount64. I would love to declare that XP is dead, and everybody has GetTickCount64.

Remove all include common/ uses in crypto_ops and tls.

a742a82

tor-bot merged commit a742a82 into torproject:master Jun 28, 2018
0 of 2 checks passed

torproject / tor Public

Freestyle refactor #191

Freestyle refactor #191

nmathewson commented Jun 28, 2018

torproject / tor Public

Freestyle refactor #191

Freestyle refactor #191

Conversation

nmathewson commented Jun 28, 2018