Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tor Trac #25140]: Add wildcard support to %include on configuration files #1915

Conversation

Labels
None yet
Projects
None yet
3 participants
@Jigsaw52
Copy link
Contributor

@Jigsaw52 Jigsaw52 commented Jun 3, 2020

No description provided.

@coveralls
Copy link

@coveralls coveralls commented Jun 3, 2020

Pull Request Test Coverage Report for Build 9880

  • 132 of 151 (87.42%) changed or added relevant lines in 4 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.03%) to 64.451%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/lib/fs/conffile.c 49 51 96.08%
src/lib/fs/files.c 0 4 0.0%
src/lib/fs/path.c 79 92 85.87%
Files with Coverage Reduction New Missed Lines %
src/lib/fs/conffile.c 1 96.43%
Totals Coverage Status
Change from base Build 9878: 0.03%
Covered Lines: 51623
Relevant Lines: 80097

💛 - Coveralls

@Jigsaw52 Jigsaw52 force-pushed the torrc-include-wildcards-25140_rebasedv2 branch 2 times, most recently from 2ea63c3 to 8ac24ec Jun 3, 2020
@Jigsaw52 Jigsaw52 changed the title [Tor Trac #25140] Add wildcard support to %include on configuration files [Tor Trac #25140]: Add wildcard support to %include on configuration files Jun 6, 2020
Jigsaw52 added 4 commits Jul 15, 2020
Also adds generic tor_glob function to expand globs.
Tests %include with files and folders, modifying and reloading
the config file with sandbox enabled and reponse of SAVECONF and
getinfo config-can-saveconf control commmands.
Tests that used options_init_from_string were not freeing calling
config_free_all().
@Jigsaw52 Jigsaw52 force-pushed the torrc-include-wildcards-25140_rebasedv2 branch from 8ac24ec to ac2c4b1 Jul 15, 2020
@Jigsaw52 Jigsaw52 force-pushed the torrc-include-wildcards-25140_rebasedv2 branch from ca552c2 to 60c436d Aug 12, 2020
@torproject-pusher torproject-pusher merged commit e151442 into torproject:master Aug 12, 2020
2 checks passed
@Jigsaw52 Jigsaw52 deleted the torrc-include-wildcards-25140_rebasedv2 branch Aug 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment