Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tor Trac #30642]: Add an ed25519_identity file to the data directory (Revision 1) #1917

Closed
wants to merge 3 commits into from

Conversation

Labels
None yet
Projects
None yet
4 participants
@neelchauhan
Copy link
Contributor

@neelchauhan neelchauhan commented Jun 4, 2020

PR: https://trac.torproject.org/projects/tor/ticket/30642

@coveralls
Copy link

@coveralls coveralls commented Jun 4, 2020

Pull Request Test Coverage Report for Build 9208

  • 13 of 22 (59.09%) changed or added relevant lines in 2 files are covered.
  • 4703 unchanged lines in 36 files lost coverage.
  • Overall coverage increased (+0.1%) to 64.294%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/app/main/main.c 0 2 0.0%
src/feature/relay/router.c 13 20 65.0%
Files with Coverage Reduction New Missed Lines %
src/feature/hs/hs_common.c 1 84.48%
src/feature/hs/hs_service.c 1 74.53%
src/core/or/versions.c 3 96.23%
src/feature/nodelist/routerlist.h 4 22.22%
src/feature/nodelist/dirlist.c 6 77.78%
src/feature/nodelist/routerset.c 8 94.55%
src/feature/nodelist/fmt_routerstatus.c 11 82.86%
src/app/config/resolve_addr.c 14 90.54%
src/lib/tls/buffers_tls.c 18 39.68%
src/feature/relay/circuitbuild_relay.c 19 88.48%
Totals Coverage Status
Change from base Build 9028: 0.1%
Covered Lines: 51214
Relevant Lines: 79656

💛 - Coveralls

log_notice(LD_GENERAL, "Your Tor %s identity key %s is '%s %s'",
hashed ? "bridge's hashed" : "server's",
ed25519_identity ? "ed25519 key" : "fingerprint",
options->Nickname, fingerprint);
Copy link
Contributor

@dgoulet-tor dgoulet-tor Jun 25, 2020

Small problem here. Log output looks like:

Jun 25 08:06:41.194 [notice] Your Tor server's identity key ed25519 key is 'mytest xyfc3udfBrGnhD8i+4bmbdN5QMBNfZ9Xyl1aR/6dYcY'

I would probably go for: Your Tor server's identity key ed25519 fingerprint is ...

@torproject-pusher torproject-pusher deleted the branch torproject:master May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment