Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve our clang-format.sh script #1929

Merged

Conversation

Labels
None yet
Projects
None yet
3 participants
@nmathewson
Copy link
Contributor

@nmathewson nmathewson commented Jun 11, 2020

Previously, this script ran over every C file in our source code,
which took up to a minute on my desktop.

Instead, the script now has several modes that it can run in, to
minimize the time spent and improve useful output. It should now be
suitable for everyday use and git hooks. I hope.

I've also renamed this script, so that we can keep using it in the
future if we were to move to some tool other than clang-format.

Previously, this script ran over every C file in our source code,
which took up to a minute on my desktop.

Instead, the script now has several modes that it can run in, to
minimize the time spent and improve useful output.  It should now be
suitable for everyday use and git hooks.  I hope.

I've also renamed this script, so that we can keep using it in the
future if we were to move to some tool other than clang-format.
@coveralls
Copy link

@coveralls coveralls commented Jun 11, 2020

Pull Request Test Coverage Report for Build 9091

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 179 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.01%) to 64.316%

Files with Coverage Reduction New Missed Lines %
src/feature/hs/hs_common.c 1 84.48%
src/feature/client/entrynodes.c 178 86.3%
Totals Coverage Status
Change from base Build 9083: 0.01%
Covered Lines: 51133
Relevant Lines: 79503

💛 - Coveralls

@torproject-pusher torproject-pusher merged commit 279225a into torproject:master Jun 24, 2020
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment