Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove util and compat #193

Merged
merged 18 commits into from Jun 29, 2018
Merged

Remove util and compat #193

merged 18 commits into from Jun 29, 2018

Conversation

Reviewers

@dgoulet-tor dgoulet-tor

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@nmathewson @coveralls @dgoulet-tor @tor-bot
@nmathewson
Copy link
Contributor

@nmathewson nmathewson commented Jun 29, 2018

No description provided.

nmathewson added 18 commits Jun 29, 2018
@nmathewson
Move tor_get_avail_disk_space() to lib/fs
973afcc
@nmathewson
Move fd and memory-info functions.
0362cdc
@nmathewson
Remove read_all and write_all
40199b1 
These had become wrappers around their fd and socket variants; there
were only a few users of the original functions still remaining.
@nmathewson
Move bool_eq and bool_neq to lib/intmath
77bc65b
@nmathewson
Move SUBTYPE_P into compat_compiler.h
207fc4c
@nmathewson
Extract get_uname to lib/osinfo.
e095702
@nmathewson
Extract getpass to a new lib/term library
4e11c2c 
(Term is short for terminal)
@nmathewson
Remove compat.c and util.c
e269044
@nmathewson
Remove an errant (and unused) include permission in lib/tls
b21108f
@nmathewson
Move SIO_IDEAL_SEND_BACKLOG_QUERY into socket.h
080069c
@nmathewson
Extract socks5_status_t
31897a2 
I'm not sure of the best place to put this header long-term, since
both or/*.c and tools/tor-resolve.c use it.
@nmathewson
Remove windows libraries from util.h and compat.h
71e56c7
@nmathewson
Remove non-windows system includes from compat.h and util.h
714788b
@nmathewson
Combine compat.h into util.h
35e1c49 
This is now just a collection of frequently-used headers.
@nmathewson
Remove util.h and compat.h includes from src/common
4212a13
@nmathewson
Stop using util.h and compat.h in src/tools
666e3e5
@nmathewson
Stop using util.h and compat.h in src/trunnel/
077176a
@nmathewson
Eliminate compat.h
6ac64e1
dgoulet-tor
dgoulet-tor reviewed Jun 29, 2018
View changes
.gitignore Outdated
@@ -195,6 +195,8 @@ uptime-*.json
/src/lib/libtor-meminfo-testing.a
/src/lib/libtor-net.a
/src/lib/libtor-net-testing.a
/src/lib/libtor-osinfo.a
/src/lib/libtor-osinfo-testing.a
Copy link
Contributor

@dgoulet-tor dgoulet-tor Jun 29, 2018

So here is an idea. How about we have an "os" library for which we could put all the things we use to interact with the operating system.

I'm thinking about this get_uname() but also, set file desc, get available memory, etc... ?

Copy link
Contributor Author

@nmathewson nmathewson Jun 29, 2018

Hm. I'm not so sure there. Isn't everything that ends in a syscall "something that interacts with the operating system?"

src/common/include.am
@@ -54,6 +54,7 @@ COMMONHEADERS = \
src/common/compat_libevent.h \
src/common/handles.h \
src/common/procmon.h \
src/common/socks5_status.h \
Copy link
Contributor

@dgoulet-tor dgoulet-tor Jun 29, 2018

To respond to the commit message, my guts feeling tells me that we probably want a socks5 library at some point for which it should be (I think!) only visible to the "tor client" component.

Copy link
Contributor Author

@nmathewson nmathewson Jun 29, 2018

Yeah, I agree

@coveralls
Copy link

@coveralls coveralls commented Jun 29, 2018

Coverage Status

Coverage decreased (-0.01%) to 59.875% when pulling 6ac64e1 on nmathewson:remove_util_and_compat into f0319fc on torproject:master.

@tor-bot tor-bot merged commit 6ac64e1 into torproject:master Jun 29, 2018
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment