[Tor Trac #34065]: Make routerset_contains_router() support IPv6 #1931
Conversation
Pull Request Test Coverage Report for Build 9181
|
neelchauhan
force-pushed
the
bug34065
branch
2 times, most recently
from
e0a423f
to
1e0a36f
nmathewson
reviewed
Jun 22, 2020
nmathewson
reviewed
Jun 22, 2020
src/feature/nodelist/routerset.c
Outdated
| routerset_contains(set, &addr_v4, ri->or_port, ri->nickname, | ||
| ri->cache_info.identity_digest, country); | ||
| int v6_ret = | ||
| routerset_contains(set, &ri->ipv6_addr, ri->ipv6_orport, ri->nickname, |
- Doing these two separate checks means that routerset_contains_router will check the nickname and identity twice. That's wasted computation that can add up. It would be better to arrange things so that those only get checked once.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
PR: https://trac.torproject.org/projects/tor/ticket/34065
The text was updated successfully, but these errors were encountered: