Shrink or h more #196

nmathewson · 2018-07-01T19:37:31Z

No description provided.

or.h should really include only the minimum of stuff from or/*, common/*, and lib/*.

These all have a logical header to go in.

Fewer modules needed this than I had expected.

I decided to have this file included from config.h, though, since it is used nearly everywhere.

coveralls · 2018-07-01T19:56:59Z

Coverage decreased (-0.008%) to 59.861% when pulling 518ebe1 on nmathewson:shrink_or_h_more into adcd1d8 on torproject:master.

nmathewson added 13 commits Jul 1, 2018

Combine DH_BYTES and DH_KEY_LEN; put them in a lib/defs header.

7a61a92

Remove needless includes from or.h

471104e

or.h should really include only the minimum of stuff from or/*, common/*, and lib/*.

Remove other needless includes include from or/*.h

5008264

Minimize headers that include crypto_formats and x25519 stuff

1743dac

Extract various enums and tiny structs from or.h

6da0311

These all have a logical header to go in.

Extract addr_policy_t into a new header.

f54a5cb

Extract more constants from or.h

49f88e7

Move ext_or_cmd_t to proto_ext_or

6ccd98f

Pull a couple more enums from or.h

f75357e

Extract or_state_t to its own header.

986d761

Fewer modules needed this than I had expected.

Extract or_options_t from or.h

1311637

I decided to have this file included from config.h, though, since it is used nearly everywhere.

Remove system headers from or.h

6c440da

fixup! Remove system headers from or.h

8d562c0

fixup! Extract or_options_t from or.h

518ebe1

torproject-pusher merged commit 518ebe1 into torproject:master Jul 3, 2018
2 of 3 checks passed

torproject / tor Public