Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ntor_ref.py: pass only strings to subprocess.Popen #198

Merged
merged 1 commit into from Jul 3, 2018
Merged

ntor_ref.py: pass only strings to subprocess.Popen #198

merged 1 commit into from Jul 3, 2018

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@nmathewson @coveralls @torproject-pusher
@nmathewson
Copy link
Contributor

@nmathewson nmathewson commented Jul 2, 2018

Recent Python3 versions seem to require this on Windows.

Fixes bug 26535; bug introduced in f4be34f, which
was apparently intended itself as a Python3 workaround.
@nmathewson
ntor_ref.py: pass only strings to subprocess.Popen
fc5f8b6 
Recent Python3 versions seem to require this on Windows.

Fixes bug 26535; bug introduced in f4be34f, which
was apparently intended itself as a Python3 workaround.
@coveralls
Copy link

@coveralls coveralls commented Jul 2, 2018

Coverage Status

Coverage decreased (-0.02%) to 50.293% when pulling fc5f8b6 on nmathewson:bug26535_029 into 1953a7e on torproject:maint-0.2.9.

@torproject-pusher torproject-pusher merged commit fc5f8b6 into torproject:maint-0.2.9 Jul 3, 2018
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment