Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#21349: Refactor long functions in entrynodes.c (2) #200

Closed
wants to merge 9 commits into from
Closed

#21349: Refactor long functions in entrynodes.c (2) #200

wants to merge 9 commits into from

Conversation

Reviewers

@asn-d6 asn-d6

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@rl1987 @coveralls @tlyu @asn-d6
@rl1987
Copy link
Contributor

@rl1987 rl1987 commented Jul 2, 2018

https://trac.torproject.org/projects/tor/ticket/21349
rl1987 added 7 commits Jul 2, 2018
@rl1987
Split sampled_guards_update_from_consensus() into subfunctions
09d935c
@rl1987
Make entry_guards_update_primary() shorter
96a0c12
@rl1987
Split select_entry_guard_for_circuit()
49b4452
@rl1987
Add changes file
6c4c886
@rl1987
Convert REMOVE_UNLISTED_GUARDS_AFTER macro into function
122ad11
@rl1987
Fix function comment formatting
5453dd8
@rl1987
Make new functions return a number of entries affected
d3fcbcb
@coveralls
Copy link

@coveralls coveralls commented Jul 2, 2018 •
edited

Coverage Status

Coverage increased (+0.03%) to 59.529% when pulling 870dab7 on rl1987:ticket21349_2 into 2e5eb02 on torproject:master.

asn-d6
asn-d6 reviewed Jul 2, 2018
View changes
src/or/entrynodes.c Outdated
@@ -407,6 +404,13 @@ get_remove_unlisted_guards_after_days(void)
DFLT_REMOVE_UNLISTED_GUARDS_AFTER_DAYS,
1, 365*10);
}

static time_t
Copy link
Member

@asn-d6 asn-d6 Jul 2, 2018

Please add the trivial func doc here.

Copy link
Contributor Author

@rl1987 rl1987 Jul 3, 2018

Fixed - 9a3d655.

src/or/entrynodes.c Outdated
@@ -1411,11 +1413,11 @@ sampled_guards_update_from_consensus(guard_selection_t *gs)
approx_time() - get_guard_confirmed_min_lifetime();

/* Then: remove the ones that have been junk for too long */
n_changes +=
sampled_guards_prune_obsolete_entries(gs,
Copy link
Member

@asn-d6 asn-d6 Jul 2, 2018

Please intend the code here! :)

Copy link
Contributor Author

@rl1987 rl1987 Jul 3, 2018

Fixed in 870dab7.

rl1987 added 2 commits Jul 3, 2018
@rl1987
fixup! Convert REMOVE_UNLISTED_GUARDS_AFTER macro into function
9a3d655
@rl1987
fixup! Make new functions return a number of entries affected
870dab7
@tlyu
Copy link
Contributor

@tlyu tlyu commented Jul 25, 2018

Superseded by #246.

@tlyu tlyu closed this Jul 25, 2018
@tlyu tlyu mentioned this pull request Jul 25, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment