#21349: Refactor long functions in entrynodes.c (3) #202
Conversation
nmathewson
reviewed
Jul 11, 2018
src/lib/container/smartlist.c
Outdated
| * values are matching). Otherwise, return false. | ||
| */ | ||
| int | ||
| smartlist_shallow_eq(const smartlist_t *s1, const smartlist_t *s2) |
For consistency with smartlist_ints_eq and smartlist_strings_eq, this should probably be called smartlist_ptrs_eq
Renamed in 8a18eba.
src/lib/container/smartlist.c
Outdated
| int | ||
| smartlist_shallow_eq(const smartlist_t *s1, const smartlist_t *s2) | ||
| { | ||
| if (s1 == NULL || s2 == NULL) |
if s1 == NULL && s2 == NULL I think this function should return 1.
Fixed in ac40d0e.
src/or/entrynodes.c
Outdated
| @@ -404,6 +404,17 @@ get_remove_unlisted_guards_after_days(void) | |||
| DFLT_REMOVE_UNLISTED_GUARDS_AFTER_DAYS, | |||
| 1, 365*10); | |||
| } | |||
|
|
|||
| /** | |||
| * If a guard has been unlisted for this many seconds continuously, we | |||
Usually we'll document a function by using a verb to describe what it does, like "Return the number of seconds after which we remove a guard that..."
Reworded in be9401d .
src/or/entrynodes.c
Outdated
| SMARTLIST_FOREACH_BEGIN(gs->sampled_entry_guards, entry_guard_t *, guard) { | ||
| /* XXXX #20827 check ed ID too */ | ||
| const int is_listed = entry_guard_is_listed(gs, guard); | ||
|
|
||
| if (is_listed && ! guard->currently_listed) { | ||
| ++n_changes; |
What's the point of these changes?
None really, just a byproduct of some now-squashed fixup commits. Changed it back in 4a82c90 .
|
Superseded by #246. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
https://trac.torproject.org/projects/tor/ticket/21349
The text was updated successfully, but these errors were encountered: