Ticket26626: require and use the standard C integer headers, types, and macros. #207
Conversation
Recent Python3 versions seem to require this on Windows. Fixes bug 26535; bug introduced in f4be34f, which was apparently intended itself as a Python3 workaround.
Recent Python3 versions seem to require this on Windows. Fixes bug 26535; bug copied from ntor_ref.py on 0.3.1.1-alpha.
We've been silently requiring stdint.h for a while now, and nobody has complained. Closes ticket 26626.
Casting before printf was necessary; now it's not so smart. We don't have SIZEOF_UINT8_T any more.
The standard is printf("%"PRIu64, x);
These were necessary long ago to work around a bug in VC6.
These were mostly cases where our previous macros had been casting, and the values that we were trying to printf were not in fact uint64_t.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
No description provided.
The text was updated successfully, but these errors were encountered: