Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow single DA if explicitly configured #208

Merged
merged 1 commit into from Jul 9, 2018
Merged

Allow single DA if explicitly configured #208

merged 1 commit into from Jul 9, 2018

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@gsomlo @coveralls @torproject-pusher
@gsomlo
Copy link
Contributor

@gsomlo gsomlo commented Jul 3, 2018

When on a private network a single directory authority is explicitly
configured, allow that DA's instace of tor to pick itself as its own
DA, by having router_pick_dirserver_generic() set the PDS_ALLOW_SELF
flag when the list of potential sources contains only one element.
This would subsequently allow router_pick_trusteddirserver_impl() to
calculate is 'requreother' condition as 'false', enabling it to pick
itself as a valid DA candidate.

Fixes #25928

Signed-off-by: Gabriel Somlo gsomlo@gmail.com
@gsomlo
Allow single DA if explicitly configured
97fad99 
When on a private network a single directory authority is explicitly
configured, allow that DA's instace of tor to pick itself as its own
DA, by having router_pick_dirserver_generic() set the PDS_ALLOW_SELF
flag when the list of potential sources contains only one element.
This would subsequently allow router_pick_trusteddirserver_impl() to
calculate is 'requreother' condition as 'false', enabling it to pick
itself as a valid DA candidate.

Fixes #25928

Signed-off-by: Gabriel Somlo <gsomlo@gmail.com>
@coveralls
Copy link

@coveralls coveralls commented Jul 3, 2018

Coverage Status

Coverage decreased (-0.002%) to 59.491% when pulling 97fad99 on gsomlo:gls-single-da into 2878dad on torproject:master.

@torproject-pusher torproject-pusher merged commit 97fad99 into torproject:master Jul 9, 2018
3 checks passed
@gsomlo gsomlo deleted the gls-single-da branch Jul 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment