Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ticket26526 26532 #221

Merged
merged 5 commits into from Jul 10, 2018
Merged

Ticket26526 26532 #221

merged 5 commits into from Jul 10, 2018

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@nmathewson @coveralls @torproject-pusher
@nmathewson
Copy link
Contributor

@nmathewson nmathewson commented Jul 10, 2018

No description provided.

nmathewson added 5 commits Jul 10, 2018
@nmathewson
Refactor ipv[46].[ch]
5d8336c 
These are now combined into an inaddr.[ch], since their purpose is
to implement functions for struct in_addr and struct in6_addr.

The definitions for in6_addr and its allies are now in a separate
header, inaddr_st.h.

Closes ticket 26532.
@nmathewson
Move tor_addr_{,port_}lookup to resolve.c
c2ddb7b
@nmathewson
Remove all users of addr_port_lookup outside of address.c
2f657a1 
This function has a nasty API, since whether or not it invokes the
resolver depends on whether one of its arguments is NULL.  That's a
good way for accidents to happen.

This patch incidentally makes tor-resolve support socks hosts on
IPv6.
@nmathewson
Remove addr_port_lookup.
8de48c1 
This lets us cut the dependency from address.c to resolve.c: the
address.c module now has no paths to the libc resolver in it.
@nmathewson
Isolate resolve.h usage in the modules that really need it.
a2c44a7 
(Almost none of Tor should actually need to touch the platform resolver.)
@coveralls
Copy link

@coveralls coveralls commented Jul 10, 2018

Coverage Status

Coverage decreased (-0.008%) to 59.494% when pulling a2c44a7 on nmathewson:ticket26526_26532 into ef106ce on torproject:master.

@torproject-pusher torproject-pusher merged commit a2c44a7 into torproject:master Jul 10, 2018
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment