Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug26627 032 - HSv3 throws many "RSA identity key was not as expected" #248

Closed
wants to merge 6 commits into from
Closed

Bug26627 032 - HSv3 throws many "RSA identity key was not as expected" #248

wants to merge 6 commits into from

Conversation

Reviewers
No reviews
Assignees

@teor2345 teor2345

Labels
bug
Projects
None yet
Milestone
No milestone
4 participants
@teor2345 @coveralls @nmathewson @neelchauhan
@teor2345
Copy link
Contributor

@teor2345 teor2345 commented Jul 25, 2018

https://trac.torproject.org/projects/tor/ticket/26627
neelchauhan and others added 6 commits Jul 24, 2018
@neelchauhan @teor2345
Introduce node_get_curve25519_onion_key()
0d491a5
@neelchauhan @teor2345
Make setup_introduce1_data() take a node_t instead of an extend_info_t
124146f 
Clients add rendezvous point IPv6 addresses to introduce cell link specifiers,
when the node has a valid IPv6 address.

Also check the node's IPv4 address is valid before adding any link specifiers.

Implements #23577.
@nmathewson @teor2345
Add a function to check for support for "protocol X or later"
d00b5b9 
Also, add unit tests for this new function and for the regular
"does this list include support for protocol X" code.
@nmathewson @teor2345
Split the behavior of node_supports_ed25519_link_authentication().
3109269 
Before, this function meant "can we connect to this node and
authenticate it using its ed25519 key?"  Now it can additionally
mean, "when somebody else connects to this node, do we expect that
they can authenticate using the node's ed25519 key"?

This change lets us future-proof our link authentication a bit.

Closes ticket 20895.  No backport needed, since ed25519 link
authentication support has not been in any LTS release yet, and
existing releases with it should be obsolete before any releases
without support for linkauth=3 are released.
@teor2345
Stop sending unsupported ed25519 link specifiers in v3 introduce cells
1f7573e 
Stop sending ed25519 link specifiers in v3 onion service introduce
cells, when the rendezvous point doesn't support ed25519 link
authentication.

Fixes bug 26627; bugfix on 0.3.2.4-alpha.
@teor2345
Stop putting unsupported ed25519 link auth in v3 onion service descs
61a48bb 
Stop putting ed25519 link specifiers in v3 onion service descriptors,
when the intro point doesn't support ed25519 link authentication.

Fixes bug 26627; bugfix on 0.3.2.4-alpha.
@teor2345 teor2345 added the bug label Jul 25, 2018
@teor2345 teor2345 self-assigned this Jul 25, 2018
@coveralls
Copy link

@coveralls coveralls commented Jul 25, 2018

Coverage Status

Coverage increased (+0.007%) to 56.278% when pulling 61a48bb on teor2345:bug26627_032 into be3a962 on torproject:maint-0.3.2.

@nmathewson
Copy link
Contributor

@nmathewson nmathewson commented Sep 30, 2018

A version of this branch has been squashed and merged.

@nmathewson nmathewson closed this Sep 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment