Bug23576 #254
Closed
Bug23576 #254
Conversation
Also: * rename to node_get_link_specifier_smartlist * rewrite to return a smartlist * add link_specifier_smartlist_free Part of 23576.
Since node_get_link_specifier_smartlist() supports IPv6 link specifiers, this refactor adds IPv6 addresses to onion service descriptors. Part of 23576, implements 26992.
asn-d6
reviewed
Aug 12, 2018
| @@ -0,0 +1,7 @@ | |||
| o Minor features (IPv6, v3 onion services): | |||
| - Onion services put IPv6 addresses in service descriptors. | |||
Nitpick: Perhaps the commit msg here should be Onion services put IPv6 addresses in service descriptors. instead of Rewrite service_intro_point_new() to take a node_t.
See my branch bug23576-rebased, where I rebased and changed this commit summary.
asn-d6
reviewed
Aug 12, 2018
| /* ed25519 identity key is optional for intro points. If the node supports | ||
| * ed25519 link authentication, we include it. */ | ||
| if (supports_ed25519_link_handshake_any) { | ||
| ls = hs_desc_link_specifier_new(ei, LS_ED25519_ID); |
I think hs_desc_link_specifier_new() is now unused and can be killed with fire.
See 71385fc on the bug23576 branch.
asn-d6
reviewed
Aug 12, 2018
| goto err; | ||
| } | ||
|
|
||
| /* Let's do a basic sanity check here so that we don't end up advertising the |
I guess this sanity check is no longer really useful?
Cleanup after 23576.
|
Fixed a long time ago. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
No description provided.
The text was updated successfully, but these errors were encountered: