Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always call tor_free_all() when exiting tor_run_main() #255

Merged
merged 1 commit into from Aug 8, 2018
Merged

Always call tor_free_all() when exiting tor_run_main() #255

merged 1 commit into from Aug 8, 2018

Conversation

Reviewers

@hellais hellais

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@nmathewson @coveralls @hellais @torproject-pusher
@nmathewson
Copy link
Contributor

@nmathewson nmathewson commented Jul 31, 2018

We would usually call it through tor_cleanup(), but in some code
paths, we wouldn't. These paths would break restart-in-process,
since leaving fields uncleared would cause assertion failures on
restart.

Fixes bug 26948; bugfix on 0.3.3.1-alpha
@nmathewson
Always call tor_free_all() when exiting tor_run_main()
a67d153 
We would usually call it through tor_cleanup(), but in some code
paths, we wouldn't. These paths would break restart-in-process,
since leaving fields uncleared would cause assertion failures on
restart.

Fixes bug 26948; bugfix on 0.3.3.1-alpha
hellais
hellais approved these changes Jul 31, 2018
View changes
Copy link
Member

@hellais hellais left a comment

I tested this and it works as expected.

@coveralls
Copy link

@coveralls coveralls commented Jul 31, 2018

Coverage Status

Coverage increased (+0.01%) to 58.214% when pulling a67d153 on nmathewson:bug26948_033 into 373b23a on torproject:maint-0.3.3.

@torproject-pusher torproject-pusher merged commit a67d153 into torproject:maint-0.3.3 Aug 8, 2018
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment