Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a new function, tor_api_get_provider_version() #257

Merged
merged 1 commit into from Aug 8, 2018
Merged

Add a new function, tor_api_get_provider_version() #257

merged 1 commit into from Aug 8, 2018

Conversation

Reviewers

@hellais hellais

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@nmathewson @coveralls @hellais @torproject-pusher
@nmathewson
Copy link
Contributor

@nmathewson nmathewson commented Jul 31, 2018

Closes ticket 26947.
@nmathewson
Add a new function, tor_api_get_provider_version()
772106c 
Closes ticket 26947.
hellais
hellais reviewed Jul 31, 2018
View changes
src/feature/api/tor_api.h
/**
* Return the name and version of the software implementing the tor_api
* functionality. Current implementors are "tor" and "libtorrunner".
*
Copy link
Member

@hellais hellais Jul 31, 2018

Would it be possible to give in the docstring an example of how the version string will be formatted and if there is some sort of assurance on the format it will have?

Copy link
Member

@hellais hellais Jul 31, 2018

FWIW when I run this I get back this version string:

- running test_tor_api_get_provider_version()
b'tor 0.3.5.0-alpha-dev'

I assume the Added comment is taking into account the fact that you will bump the version when this is merged.

@coveralls
Copy link

@coveralls coveralls commented Jul 31, 2018

Coverage Status

Coverage decreased (-0.002%) to 59.53% when pulling 772106c on nmathewson:ticket26947 into 7e4ac02 on torproject:master.

@torproject-pusher torproject-pusher merged commit 772106c into torproject:master Aug 8, 2018
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment